Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to RN 0.65.1 #48

Merged
merged 20 commits into from
Sep 12, 2021
Merged

Updating to RN 0.65.1 #48

merged 20 commits into from
Sep 12, 2021

Conversation

kanzitelli
Copy link
Owner

No description provided.

@kanzitelli
Copy link
Owner Author

Everything works well, except for the crash on Android causing by RNN (however, works on iOS).

So, now waiting for RNN v8 :)

@kanzitelli
Copy link
Owner Author

  • Now it is working with RNN v7.18.1 (w/ small patch) and react-native-mmkv v1.2.5
  • Hermes is on
  • Flipper initialization for Android is commented for now

@kanzitelli
Copy link
Owner Author

kanzitelli commented Aug 22, 2021

It crashes on Android when I toggle the theme 2-3 times in the Settings tab and shows this error (from logcat):

E/libc++abi: terminating with uncaught exception of type std::runtime_error: Unable to retrieve jni environment. Is the thread attached?

Not sure from which library this is coming, needs more investigation. My first thought was bc of MMKV but I have tried Async Storage and it crashed as well. So maybe it happens because of the RNN's setDefaultOptions or mergeOptions.

@Mohamed-kassim
Copy link

Mohamed-kassim commented Aug 23, 2021

@kanzitelli current crash is related to react-native-reanimated compatibility issues with rn65 You can check these issues
#software-mansion/react-native-reanimated#2256 (comment)
software-mansion/react-native-reanimated#2290 (comment)

@kanzitelli
Copy link
Owner Author

Thank you @Mohamed-kassim for the links!

@kanzitelli
Copy link
Owner Author

I have dig into more and found out that this error

E/libc++abi: terminating with uncaught exception of type std::runtime_error: Unable to retrieve jni environment. Is the thread attached?

happens when I try to change key of a Root component (when changing ui.themeMode) from utils/designSystem.tsx-->withThemeModes(). Also, when I try to call Navigation.setRoot() second time (not sure if I can do that) during an app launch.

@kanzitelli kanzitelli merged commit fe4e61c into master Sep 12, 2021
@kanzitelli kanzitelli deleted the rn-0.65.1 branch September 12, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants