Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement insertunsafely command #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kanzure
Copy link
Owner

@kanzure kanzure commented Mar 1, 2022

This may not be a good idea to use. It directly inserts webcash into the wallet without securing it, and it doesn't use the deterministic wallet.

probably shouldn't exist

This may not be a good idea to use. It directly inserts webcash into the
wallet without securing it, and it doesn't use the deterministic wallet.

probably shouldn't exist
@@ -494,6 +494,43 @@ def insertmany(webcash):
save_webcash_wallet(webcash_wallet)
print(f"Done! Saved e{merged_webcash.amount} in the wallet.")

@cli.command("insertunsafely")
Copy link

@jokpine jokpine May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@cli.command("insertunsafely")
@cli.command("insertunsafely", short_help="Directly insert the given webcash into the wallet. WARNING: This is unsafe: webcash status is not checked on insertion and the deterministic wallet is not used (recovery will not catch any webcash inserted in this manner).", hidden=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants