-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TS path aliases, allow HMR and environment variables validation using zod #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, but I would have an urge for path aliasing, might need discussion.
Leaving this to other reviewer.
Yeah, it's weird that it need |
"module": "ESNext", | ||
"lib": ["ESNext"], | ||
"target": "esnext", | ||
"module": "commonjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commonjs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Node ESModule compatibility is bad
thank you for the suggestion, zod env validation has been added here and i added you as a co author 78189c3 |
Close this since it outdated |
What I did