This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
fix @Emit return value to make it transparent #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for your PR! |
|
Thanks for merging! Could you release a new tagged version, please? I need this for my project |
kaorun343
pushed a commit
that referenced
this pull request
May 8, 2019
|
Please download the latest version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Emitdecorator is handling the decorated function's promise but not returning it. This causes issues like not being able to get the result calling the decorated method or the prevention of a right exception propagation. One example of the latest is demonstrated in this fiddle.Returning the promise or value we let another functions and decorators to handle it.