Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show docset size before download #57

Open
mandeldl opened this issue Aug 27, 2017 · 6 comments
Open

Feature request: Show docset size before download #57

mandeldl opened this issue Aug 27, 2017 · 6 comments

Comments

@mandeldl
Copy link

On iOS devices it'd be helpful to know in advance how large a docset is.

@nexon
Copy link

nexon commented Jan 27, 2019

@Kapeli Can we add a node or attribute to the xml of the each feed that give you the size?. After that it will be easy to add the file size to the app.

@Kapeli
Copy link
Owner

Kapeli commented Jan 27, 2019

@nexon Have you considered sending a HEAD request to the server requesting the archive and checking the Content-Length?

@nexon
Copy link

nexon commented Jan 27, 2019

@Kapeli Yes, but is not the best option here since you will need to send N request where N is the quantity of visible cells, in which case is a waste of resources.

Also you need to consider cancelling the request when the user press for downloading.
Another problem is what happen with the request (HEAD) when the user scroll. Should be cancelled?, we should get a reference to the Feed Object when doing the request so we don't cancel it and we wait for the result and we put it in the Feed Object (we need to avoid leaking memory)?

@Kapeli
Copy link
Owner

Kapeli commented Jan 27, 2019

How would all this be different if you had an attribute in the XML itself?

@stevapple
Copy link

For main docsets and cheat sheets, maybe you can maintain an XML feed especially for the sizes of each docset and cheatsheet? For 3rd-party ones, maybe sizes can be integrated into the main feed.

@Kapeli
Copy link
Owner

Kapeli commented Jan 28, 2019

For main docsets I plan on moving to a JSON feed (like the cheatsheet one), which will include sizes. This won't come anytime soon though.

For cheatsheets I don't see a point in showing the size. All of them are less than 200 KB in size. Only LaTeX_Math_Symbols is 1.1MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants