Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved target names variables #10

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

ademariag
Copy link

@ademariag ademariag commented Feb 21, 2023

When using the compose_node_name: true, for example for the following

gcp\
  project1.yml
  project2.yml

then the inventory will render as such:

parameters:
  _reclass_:
    environment: base
    name:
      full: gcp.project1
      short: gcp

while the expected behaviour for Kapitan would be

parameters:
  _reclass_:
    environment: base
    name:
      full: gcp.project1
      short: project1

Additionally, this PR also adds support for exposing the list of parts composing the path

parameters:
  _reclass_:
    environment: base
    name:
      full: gcp.project1
      parts:
        - gcp
        - project1
      path: gcp/project1
      short: project1

Copy link

@uberspot uberspot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@uberspot uberspot merged commit 856b34c into develop Feb 22, 2023
@uberspot uberspot deleted the improve_target_naming_variables branch February 22, 2023 18:14
gburiola added a commit to kapicorp/kapitan that referenced this pull request Feb 23, 2023
uberspot pushed a commit to kapicorp/kapitan that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants