Skip to content

Commit

Permalink
fix: cmd + w doesn't close the window on macOS (bitwarden#714)
Browse files Browse the repository at this point in the history
cmd + w doesn't close the window on macOS. Based on @cscharf explanation - bitwarden/desktop#714 (comment) - it seems that issue was introduced in response to erroneous Apple Store approver request. The code change reversed this change.
  • Loading branch information
kapitainsky committed Apr 13, 2021
1 parent 8276748 commit add5aee
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/electron/baseMenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import {
import { I18nService } from '../abstractions/i18n.service';
import { WindowMain } from './window.main';

import { isMacAppStore } from './utils';

export class BaseMenu {
protected editMenuItemOptions: MenuItemConstructorOptions;
protected viewSubMenuItemOptions: MenuItemConstructorOptions[];
Expand Down Expand Up @@ -143,7 +141,7 @@ export class BaseMenu {
},
{
label: this.i18nService.t('close'),
role: isMacAppStore() ? 'quit' : 'close',
role: 'close',
},
];
}
Expand Down

0 comments on commit add5aee

Please sign in to comment.