Disable ambiguous blocks in specs. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- With our current config, we get a lot of linter errors from code
that looks like this:
expect { ... }.to change { MyModel.count }
The linter error looks like this:
Parenthesize the param `change { MyModel.count }` to make sure
that the block will be associated with the `change` method call.
This is rspec syntax and should not be flagged as a linter issue.
- See rubocop/rubocop#4222
pk-nb
approved these changes
Apr 30, 2018
|
good time to change, maybe with a batch for the other items |
|
Yes, I figured we can include this with all the other changes. Should I merge now or let you manage that? |
|
Let's hold off on merge until Thursday. I might ask everyone who has a change to help champion copying configs |
|
I think I ran into this before so nice to fix it. |
adsteel
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we get rubocop linter issues for code like this
This is valid rspec syntax and should not trigger a linter error.
See rubocop/rubocop#4222 for a conversation about this same issue, which triggered a change to the default rubocop configuration.