fix replication with custom keypairs, and add a test #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gpi
force-pushed
the
fix-keypair-issue
branch
from
83e1fdd
to
919e790
Compare
|
well done for catching this! @kyphae |
|
Ha, great catch!
…On 12/06 01:28, Kieran Gibb wrote:
This fixes a bug introduced in the last keypair pull request, where the previous secret key was being assigned to the next hypercore in opts, causing keys not to match and replication to fail.
You can view, comment on, or merge this pull request online at:
#41
-- Commit Summary --
* fix replication with custom keypairs, and add a test
-- File Changes --
M index.js (2)
M test/basic.js (53)
-- Patch Links --
https://github.com/kappa-db/multifeed/pull/41.patch
https://github.com/kappa-db/multifeed/pull/41.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#41
|
|
5.1.1
|
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in the last keypair pull request, where the previous secret key was being assigned to the next hypercore in opts, causing keys not to match and replication to fail.