Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Adding action url to liberty admin center #73

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

juniartisu
Copy link
Member

No description provided.

@juniartisu juniartisu self-assigned this Feb 10, 2020
Copy link
Member

@cvignola cvignola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the entire action conditional based on ocp/okd, not just the url-pattern.

e.g.
if okd/ocp
name:
text:
url-pattern:
etc
end

Copy link
Member

@cvignola cvignola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must also update kappnav/ui/nls/kappnav.properties with the nls definitions specified on text.nls and description.nls. BTW, I think we need to go back and do that for appmetrics action, too.

@juniartisu juniartisu merged commit e2aea59 into master Feb 11, 2020
@juniartisu juniartisu deleted the Issue125-admincenterurlaction branch March 5, 2020 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants