Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset based pagination #75

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Offset based pagination #75

merged 6 commits into from
Jul 4, 2023

Conversation

mensfeld
Copy link
Member

@mensfeld mensfeld commented Jul 4, 2023

This PR switches how we manage offsets for Kafka topics data.

Justification is here: #73

Performs much better than the page based and is user friendly.

@mensfeld mensfeld requested a review from nijikon July 4, 2023 11:29
@mensfeld mensfeld self-assigned this Jul 4, 2023
@mensfeld mensfeld added enhancement New feature or request explorer Things related with Kafka messages explorer labels Jul 4, 2023
Copy link
Member

@nijikon nijikon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mensfeld mensfeld merged commit a7c4794 into master Jul 4, 2023
13 checks passed
@mensfeld mensfeld deleted the offset-based-pagination branch July 4, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request explorer Things related with Kafka messages explorer
Development

Successfully merging this pull request may close these issues.

None yet

2 participants