Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New download dialog shouldn't take focus #333

Closed
jastax opened this issue Oct 9, 2020 · 23 comments · Fixed by #392
Closed

New download dialog shouldn't take focus #333

jastax opened this issue Oct 9, 2020 · 23 comments · Fixed by #392
Assignees

Comments

@jastax
Copy link

jastax commented Oct 9, 2020

The new download dialog takes focus for every jar that is loaded. Downloading many jars means the users computer is more or less unusable for that time. Could it become one dialog that doesn't take the focus for every new jar?

@sclassen
Copy link
Member

sclassen commented Oct 9, 2020

@hendrikebbers can you take this up

@janakmulani
Copy link
Contributor

Hi,

I hope you are using OWS 1.2.0 or greater.

I tried downloading many large jars from here.

There is one dialog (see picture) that shows progress of each jar being downloaded. This dialog does not take away focus i.e I can continue working on a word doc while OWS is downloading jars and displaying progress in the dialog.

Jar-Download-Dialog

@jastax
Copy link
Author

jastax commented Oct 13, 2020

Hi,

I'm using 1.2.1 on Linux with no parallel downloading.

@jastax
Copy link
Author

jastax commented Oct 13, 2020

video

@jastax
Copy link
Author

jastax commented Oct 13, 2020

The file you provided above does work the way you described. Maybe the multiple download dialogs happen on extensions only?

@janakmulani
Copy link
Contributor

Thanks for confirming.

So you have a jnlp with extensions which have additional jars.

I will try to reproduce your issue by creating an extension jnlps.

@janakmulani
Copy link
Contributor

I created jnlp with extensions.

For each ext jnlp and the main jnlp the download progress dialog comes up. However it does not take away focus from other apps such as word or file explorer. It only takes focus away from the OWS consoles (which is OK).

DownloadDlgFocus

@jastax
Copy link
Author

jastax commented Oct 21, 2020

On Linux (in my case Ubuntu) it takes the focus from any app

@jastax
Copy link
Author

jastax commented Oct 21, 2020

I pressed x the whole time

video

@janakmulani
Copy link
Contributor

I tested on Windows.

@sclassen can you please test jnlp with extensions on Linux?

@jastax
Copy link
Author

jastax commented Dec 9, 2020

I'm testing 1.3.1 on Windows and am running into the same issue. Focus is taken away

@janakmulani
Copy link
Contributor

janakmulani commented Dec 10, 2020

Did you use jnlp with extensions?. Download dialog for each extension comes up but for me it is not taking the focus away, I can continue to press 'x' in the word document without interruption.

@jastax
Copy link
Author

jastax commented Dec 11, 2020

Yes, focus is taken away when using that JNLP.
Windows 10 Enterprise, Version 1809

@janakmulani
Copy link
Contributor

@jastax So what is different between your set up and mine? I have Windows 10 Pro 10 build 18363. Which JRE is being used in your case? In my case it is Oracle JRE 11.0.9.

@jastax
Copy link
Author

jastax commented Dec 21, 2020

It's running either Oracle JDK8 or AdoptOpenJDK 8, but I can only confirm in January

@jastax
Copy link
Author

jastax commented Jan 7, 2021

Y:>java -version
openjdk version "1.8.0_265"

@janakmulani
Copy link
Contributor

@jastax I tested with AdoptOpenJDK 1.8.0_275 on Windows but I cannot reproduce the issue, i.e. focus is not lost from Word app while OWS is displaying progress dialog for downloading multiple jars in multiple extensions.

@sclassen
Copy link
Member

I can reproduce this on Linux. Looks like it is OS dependent

@jastax
Copy link
Author

jastax commented Jan 21, 2021

I can reproduce this on Linux. Looks like it is OS dependent

Thanks for confirming.

I also lost focus on Windows, but that might be due to the bug I reported for ITW and you already fixed. I will re-test on Windows after the patch is available.

@jastax
Copy link
Author

jastax commented Jan 28, 2021

OWS 1.3.2 Windows, launching the JNLP (https://download-openwebstart.com/download-test-hendrik/manyjars_with_ext.jnlp) -> Focus is still taken away.

@janakmulani
Copy link
Contributor

I tried on my Windows 10 machine. I cannot reproduce the issue => Focus remains with Word while the OWS download progress is shown:

image

@sclassen
Copy link
Member

Yes Janak, this is OS dependent. It is reproducible on Linux. We also need to check it on Mac

@jastax
Copy link
Author

jastax commented Feb 1, 2021

Yes Janak, this is OS dependent. It is reproducible on Linux. We also need to check it on Mac

On Windows I also lose focus.

First, the splash screen shows for a short time.

After that the downloads start. I'm losing focus for each extension, I think.

Some of the time there is no dialog to see at all (which is the reason why I launched multiple instances (AdoptOpenJDK/IcedTea-Web#744).

I will try to make a screen recording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants