-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strategy for user info, following Yahoo's Social Directory Web Service API end of life #4
Conversation
@karan-pathak Are you still maintaining this project? |
Dear @sunny, For an immediate solution, what I can do is merge this pull request. I looked at the code, which seems good. I believe you have already verified it. So for now this will work as the code in theory seem fine. I will also be validating the code by using the gem myself but that will be at a later point. Please let me know if this sounds okay. And again thank you very much! |
@sunny One concern, since you removed the get_user_image function which used the image size option, and replaced it with raw_info['picture'], how will the user get a different size image(32,64,128 or 192) which yahoo supports? |
Hi @karan-pathak, awesome to have you back :)
Yep, it is currently in production at cults3d.com, feel free to try it out!
I’m afraid Yahoo doesn’t support this anymore, as far as I can tell from the documentation for the user info endpoint. I’ve removed the |
Hi @sunny! I've merged your pull request and also published the latest version on Rubygems. Please let me know if everything works as you expected. Cheers! |
Fixes error since Yahoo's Social Directory Web Service API has hit its end of life.
Currently using this in production to allow people to sign-up using Yahoo without raising exceptions:
Closes #3