Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strategy for user info, following Yahoo's Social Directory Web Service API end of life #4

Merged
merged 5 commits into from
Sep 10, 2021

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Mar 19, 2020

Fixes error since Yahoo's Social Directory Web Service API has hit its end of life.

Currently using this in production to allow people to sign-up using Yahoo without raising exceptions:

gem "omniauth-yahoo_auth",
    git: "https://github.com/sunny/omniauth-yahoo_auth.git",
    branch: "openid-user-info"

Closes #3

@sunny sunny changed the title Update strategy to use user info Update strategy for user info, following Yahoo's Social Directory Web Service API end of life Mar 19, 2020
@sunny
Copy link
Contributor Author

sunny commented Jan 29, 2021

@karan-pathak Are you still maintaining this project?

@sunny sunny mentioned this pull request Sep 7, 2021
@karan-pathak
Copy link
Owner

karan-pathak commented Sep 7, 2021

Dear @sunny,
I checked all the work that you have been doing on this repo while I was not here. Thank you very much for helping out other users in the process :)
Apologies I've been gone for so long from this repository primarily because I was pursuing my masters in computer science and the workload makes me unable to spend any more time elsewhere. As my degree nears an end, I will start to maintain my previous projects and add a few more that will help others.

For an immediate solution, what I can do is merge this pull request. I looked at the code, which seems good. I believe you have already verified it. So for now this will work as the code in theory seem fine. I will also be validating the code by using the gem myself but that will be at a later point. Please let me know if this sounds okay.

And again thank you very much!

@karan-pathak
Copy link
Owner

@sunny One concern, since you removed the get_user_image function which used the image size option, and replaced it with raw_info['picture'], how will the user get a different size image(32,64,128 or 192) which yahoo supports?
Also it would be helpful if you can also update the readme, what do you say?

@sunny
Copy link
Contributor Author

sunny commented Sep 9, 2021

Hi @karan-pathak, awesome to have you back :)

I believe you have already verified it.

Yep, it is currently in production at cults3d.com, feel free to try it out!

since you removed the get_user_image function which used the image size option, and replaced it with raw_info['picture'], how will the user get a different size image(32,64,128 or 192) which yahoo supports?
Also it would be helpful if you can also update the readme, what do you say?

I’m afraid Yahoo doesn’t support this anymore, as far as I can tell from the documentation for the user info endpoint.

I’ve removed the image_size option in the README to reflect that.

@karan-pathak karan-pathak merged commit c8bb592 into karan-pathak:master Sep 10, 2021
@karan-pathak
Copy link
Owner

Hi @sunny!

I've merged your pull request and also published the latest version on Rubygems. Please let me know if everything works as you expected. Cheers!

@sunny sunny deleted the openid-user-info branch September 10, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yahoo's Social Directory Web Service API end of life
2 participants