Add tests to SubmitActionsTest, fix DELETE in ApiEndpointUtils #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed /api/delete to /api/del
| .thenReturn(responseEmpty); | ||
|
|
||
| // Delete thing succesfully | ||
| assertEquals(submitAction.delete("fullname"), true); |
There was a problem hiding this comment.
You can use assertTrue() or asserFalse() for simplicity. Can you do for the rest, as well? Don't want to leave you a comment for each of them :)
as suggested by @sfat, replaced assertEquals(res, false); with assertFalse(res);
|
@Anseriform thanks for the contribution! Really appreciate it |
sfat
added a commit
that referenced
this pull request
Mar 9, 2015
Add tests to SubmitActionsTest, fix DELETE in ApiEndpointUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @sfat, I made some tests for SubmitActions.
Also changed /api/delete to /api/del in ApiEndpointUtils.