Global .gitignore file generation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _fetch_gitignore(raw_name) | ||
|
|
||
|
|
||
| def _fetch_gitignore(raw_name, directory=''): |
There was a problem hiding this comment.
The empty string is handled as None. As a result, if the os.path was line 79 each time the filepath created would be only '/raw_name.gitignore'
There was a problem hiding this comment.
Looks good. Would be helpful to include this same note in the docs of this method.
'''one-line description of method.
longer desc spanning
multiple lines explaining what happens here.
'''
|
Thanks for the feedback, @karan 👍 |
karan
pushed a commit
that referenced
this pull request
Jan 14, 2015
Global .gitignore file generation
|
Looks good. Merging now, and will publish in a bit. Thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the output of the README on how to amend a global .gitignore.
Deals with #7 as well