Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stage class as metadata in the karaoke beatmap #1755

Closed
andy840119 opened this issue Nov 24, 2022 · 5 comments
Closed

Implement stage class as metadata in the karaoke beatmap #1755

andy840119 opened this issue Nov 24, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

What's will planning:

  1. Layout will be the part of metadata in the karaoke beatmap, and will have following type of layouts:

    • Classic -> Current version .
    • Scrolling -> Might appear in the V2.
    • Animation -> Might appear in the V2 or later
  2. Not recording time info in the Lyric class because the start time and the end time will be affected by the layout.

    • The start time and end time will not be saved in the layout metadata, or being calculated instead.
  3. Re-define the roles:

    • Beatmap: record the supported layout type and it's info.
    • Hit object(Lyric): pure and most importand data, the data field should always useful and will not being replaced if display type changed.
    • Skin: give it an id, and it will return something like texture and shader effect.
@andy840119 andy840119 added the enhancement New feature or request label Nov 24, 2022
@andy840119 andy840119 changed the title Implement layout for karaoke beatmap Implement layout class as metadata in the karaoke beatmap Nov 24, 2022
@andy840119
Copy link
Member Author

andy840119 commented Nov 24, 2022

The benefit of change:

  • Missing skin in the beatmap will only lost the style. We can use internal or default skin instead.
    • Means less logic in the skin class.
  • The data is not separated.
  • Easy to design new layout. The current layout will not being affected if create new layout.
  • Should be possible to switch the layout by mod.

@andy840119
Copy link
Member Author

Not really sure should use the same mapping role?
And the relationship between lyric and note?

@andy840119
Copy link
Member Author

andy840119 commented Nov 26, 2022

What's the step to move the layout from skin into beatmap:

@andy840119
Copy link
Member Author

Not really sure should rename the "layout" into "stage"?
Because layout info might contain style lookup info.

@andy840119
Copy link
Member Author

Close this issue due to most parts has been implemented.
Lazy to mention all the PRs.

@andy840119 andy840119 added this to the 2023.0520 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant