New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove initialize working time in the lyric. #1763

Merged

andy840119 merged 2 commits into karaoke-dev:master from andy840119:remove-init-working-time-in-the-lyric

Nov 27, 2022

Member

andy840119 commented Nov 27, 2022

Mark as part of #1755
Should initialize the lyric's hit-object start-time and duration in the processor.

andy840119 added 2 commits

November 27, 2022 15:27


          Here's no need to assign the start-time and duration in here because …

a435383

…should be calculate by beatmap processor instead.


          Remove the usage in the lrc decoder and the time-generator.

46fd1e8

andy840119 added the enhancement label

andy840119 added this to the 2022.1231 milestone

andy840119 self-assigned this

pull-request-size bot added the size/S label

andy840119 mentioned this pull request

Implement stage class as metadata in the karaoke beatmap #1755

Closed

andy840119 merged commit b92ffa5 into karaoke-dev:master

andy840119 deleted the remove-init-working-time-in-the-lyric branch

November 27, 2022 07:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment