Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the LyricCaretStateTest #2118

Closed
andy840119 opened this issue Sep 5, 2023 · 2 comments
Closed

Rewrite the LyricCaretStateTest #2118

andy840119 opened this issue Sep 5, 2023 · 2 comments
Labels
code quality Improve code quality. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.
Milestone
2023.1010

Comments

@andy840119
Copy link
Member

The test case should be focus on testing the value if user hover, click, or dragging.

說中文好了，主要是希望測試這些流程

  • hover
  • fucus down.
  • start dragging.
  • end dragging.

另外這個流程中，可以分成幾個種類:

  • 不支援 caret index 的
  • 支援 caret index，但是不支援 drag 的
  • 支援 drag 的
@andy840119 andy840119 added code quality Improve code quality. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. labels Sep 5, 2023
@andy840119
Copy link
Member Author

之前的 test case 可以保留，但可能會分成不同的 test class
會有 base class 來處理一些 dependency.

@andy840119 andy840119 mentioned this issue Sep 15, 2023
Merged
@andy840119
Copy link
Member Author

Implemented.

@andy840119 andy840119 added this to the 2023.1010 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improve code quality. Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.
Projects
None yet
Milestone
2023.1010
Development

No branches or pull requests
1 participant
@andy840119