Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the LyricCaretStateTest #2122

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Sep 15, 2023

Closes issue #2118.
花了一個星期終於寫完了,這個測試實在有夠難寫QQ

@andy840119 andy840119 added code quality Improve code quality. LyricMaker Implement lyric maker part into karaoke ruleset. labels Sep 15, 2023
@andy840119 andy840119 added this to the 2023.1010 milestone Sep 15, 2023
@andy840119 andy840119 merged commit 7aca426 into karaoke-dev:master Sep 15, 2023
3 checks passed
@andy840119 andy840119 deleted the separate-the-lyric-caret-state-test-case branch September 15, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality. LyricMaker Implement lyric maker part into karaoke ruleset. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant