New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to record which singer in lyric object. #239

Closed

andy840119 opened this issue Nov 7, 2020 · 5 comments

Labels

Member

andy840119 commented Nov 7, 2020

For now we use FontIndex property to record Style index.
But eventually this property to record list of singer.
And might use this singer to find this lyric's skin.

List of Workable way :

Record list of singer index into this property.
Record a number, and this number can convert to list of singer's id.

The text was updated successfully, but these errors were encountered:

andy840119 added the code quality label

Member Author

andy840119 commented Nov 7, 2020 •

edited

Loading

Needed in #214

Member Author

andy840119 commented Nov 8, 2020 •

edited

Loading

is better, but need to think about the naming.

...
Maybe just named ShiftingSingerIds?

Member Author

andy840119 commented Nov 8, 2020

But method1 is more reason and understandable 🤔
And it's still can save list of singer ids into single number by using JsonConversion attribute.

Member Author

andy840119 commented Nov 8, 2020 •

edited

Loading

Maybe just named Singers or SingerIds in Lyric class?

Note :
Can just use Singers because BeatmapInfo just use Bookmarks to save list of bookmark ids in osu.Game

andy840119 mentioned this issue

Save list of singer index instead of font index in lyric. #240

Merged

Member Author

andy840119 commented Nov 8, 2020

Implemented.

andy840119 closed this as completed

andy840119 mentioned this issue

Mapping lyric style to singer #21

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment