New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the recording caret algorithm might calculate wrong position if time-tag is not order in the lyric. #1166

Draft

andy840119 wants to merge 4 commits into karaoke-dev:master from andy840119:fix-the-recording-caret-algorithm

Member

andy840119 commented Mar 8, 2022

Trying to fix the case that time-tag might not always be by order in the list, which will cause the caret algorithm to get the wrong position.

pull-request-size bot added the size/M label

andy840119 marked this pull request as draft

March 8, 2022 14:28

Member Author

andy840119 commented Mar 8, 2022

確認一下:

lyric editor 中的 time-tag 是根據 list 順序還是畫面順序進行繪製?
另外，會不會影響到多個 time-tag 在同一個 index 的情況?

或許比較好的方式是在新增 time-tag 時還是讓 list 插入在正確位置?

andy840119 force-pushed the fix-the-recording-caret-algorithm branch from c1a58c5 to 0980de5 Compare

March 12, 2022 03:24

andy840119 added 4 commits

September 6, 2022 13:31


          should return enumerable instead for return list.

8b36697


          add test case list helper for testing time-tag with random state.

be35dc6


          temp.

cef77ba


          temp.

344eb05

andy840119 force-pushed the fix-the-recording-caret-algorithm branch from 9020964 to 344eb05 Compare

September 6, 2022 05:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment