Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement classic layout checks. #1826

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Implement classic layout checks. #1826

merged 6 commits into from
Jan 7, 2023

Conversation

andy840119
Copy link
Member

Implement part of #1765.
Implement the basic check for the classic stage.
Will add more check if needed.

What's done in this PR:

  • Implement the base beatmap stage check. This check class will check the stage element category also.
  • Implement the classic stage check.

@andy840119 andy840119 added the enhancement New feature or request label Jan 7, 2023
@andy840119 andy840119 added this to the 2023.0128 milestone Jan 7, 2023
This was referenced Jan 7, 2023
Open
Merged
@andy840119
Copy link
Member Author

Another 0.5K codes added.

@andy840119 andy840119 merged commit c99e2fb into karaoke-dev:master Jan 7, 2023
@andy840119 andy840119 deleted the implement-classic-layout-checks branch January 7, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
2023.0128
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andy840119