Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the architecture test for this project. #2232

Merged
merged 10 commits into from
May 19, 2024

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented May 18, 2024

Part of #2213.
As project become larger and larger, it's hard to create/modify code with correct coding style/architecture by memory.
And the decision detail might be forgot if not touch the module for several months.
It's time to make the memory into automation script to check the error.

What's have in this project:

@andy840119 andy840119 added the code quality Improve code quality. label May 18, 2024
@andy840119 andy840119 added this to the 2024.0606 milestone May 18, 2024
@andy840119
Copy link
Member Author

andy840119 commented May 18, 2024

  • Appveyor should actually test new project.
  • Test this project in the osx or linux environment.

@andy840119
Copy link
Member Author

image
Console says it runs the test, but the test is not listed in the test result 🥲
Guess it should be testsed 🤔

@andy840119 andy840119 merged commit 88a05ee into karaoke-dev:master May 19, 2024
4 checks passed
@andy840119 andy840119 deleted the add-arch-net branch May 19, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant