Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix srgb conversion #337

Open
andy840119 opened this issue Mar 28, 2023 · 1 comment
Open

Fix srgb conversion #337

andy840119 opened this issue Mar 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

https://discord.com/channels/188630481301012481/1089964051133628546
Not really sure related to this?
@andy840119 andy840119 added the bug Something isn't working label Mar 28, 2023
@andy840119 andy840119 changed the title Colour might be different if using different renderer. Fix srgb conversion Mar 29, 2023
@andy840119
Copy link
Member Author

andy840119 commented Mar 29, 2023 •
edited
Loading

https://github.com/ppy/osu-framework/pull/5715/files
Guess apply the same change in the shader can fix this issue.

[Update]
https://github.com/ppy/osu-framework/pull/5721/files
Should follow this PR instead.

@andy840119 andy840119 mentioned this issue Apr 3, 2023
Merged
andy840119 added a commit that referenced this issue Apr 3, 2023
@andy840119
Fix the sRGB issue.
de2bf76 
See:
#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119