Tags Do Not Work Correctly in karate-gatling:1.1.0 And Higher

[packleader]

In karate-gatling version 1.1.0 and higher, karateFeature("classpath:mock/cats-delete.feature@name=delete") works correctly, but karateFeature("classpath:mock/cats-delete.feature", "@name=delete") does not. It appears that the tags var-args parameter is not being honored.

Symptoms

Given: karateFeature("classpath:mock/cats-delete.feature", "@name=delete")

Expected: Only the scenarios that match @name=delete in cats-delete.feature are executed

Actual: All scenarios in cats-delete.feature are executed

Testing

The easiest way to repeat this bug is to modify line 27 of CatsSimulation.scala

val delete = scenario("delete").group("delete cats") {
   exec(karateFeature("classpath:mock/cats-delete.feature", "@name=delete"))
}

Run the tests for karate-gatling and inspect the output for the following line. This confirms that all scenarios were executed, even those without @name=delete.

GatlingSystem-akka.actor.default-dispatcher-94] INFO  com.intuit.karate - [print] this should not appear in the logs !

Fix

I think I have an idea of what's causing this, so I can investigate and submit a PR.

[packleader]

Thanks for accepting the PR. Can this issue be closed?

[ptrthomas]

@packleader the process we follow is that we keep this open with a fixed tag until the formal non-RC release.

just so you know, we are not planning an RC release until hacktoberfest gets over :| hope that's ok

[packleader]

I have confirmed that this is fixed in 1.2.0.RC2. However, I found two new bugs in the process. I'll open new issues as soon as I can assemble the minimal examples to reproduce them.

[ptrthomas]

@packleader thanks - if possible, can you also see if migration to gatling latest is straightforward, in which case we can do that too: https://gatling.io/docs/gatling/reference/current/upgrading/3.6-to-3.7/

[packleader]

I reviewed the release notes for Gatling 3.7, and I don't think any of the changes will impact us. Specifically, we don't seem to be using any of the newly-deprecated methods.

I upgraded to 3.7.3 in the karate-gatling pom, and the build still passes. I'll do some more thorough testing, but so far it looks good.

[ptrthomas]

@packleader I upgraded to 3.7.3 and the gatling maven plugin to 4.0.1. as you said it all looked ok.

but couldn't get the examples/gatling project to run via maven at all. which is very strange, tried a lot and gave up for now. that 4.0.1 gatling maven plugin simply cannot find the simulation files

[ptrthomas]

1.2.0 released