Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions node version to 16 #2151

Closed
sudhinm opened this issue Oct 26, 2022 · 7 comments · Fixed by #2155
Closed

Update Github actions node version to 16 #2151

sudhinm opened this issue Oct 26, 2022 · 7 comments · Fixed by #2155

Comments

@sudhinm
Copy link

sudhinm commented Oct 26, 2022

Node 12 has been out of support since April 2022. Github actions have started using node 16 and the usage of old version is leading to the following warning:
Screenshot 2022-10-26 at 8 08 45 PM

We need to upgrade the node version to 16 for the actions that shows warning. Follow this page for reference

@ptrthomas
Copy link
Member

@sudhinm I'm sorry this is not clear at all. which part of karate needs to change ?

@sudhinm
Copy link
Author

sudhinm commented Oct 26, 2022

@ptrthomas Sorry for the confusion. Will try to add more details if that helps.

Problem is in the github workflow. Currently your workflow is using Node version 12 and it is deprecated at the moment.
You can see warning annotations when you go to Actions tab and select any succeeded workflow run.
Screenshot 2022-10-26 at 10 00 34 PM

As you can see in your workflow config files, your actions run on v2, it should be updated to v3
Screenshot 2022-10-26 at 9 59 17 PM

Please refer this article for more details

@ptrthomas
Copy link
Member

@sudhinm thanks that makes sense. re-opening and tagging as help wanted

@ptrthomas ptrthomas reopened this Oct 26, 2022
Rajpratik71 added a commit to Rajpratik71/karate that referenced this issue Oct 28, 2022
Closes karatelabs#2151

Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
@ptrthomas
Copy link
Member

@Rajpratik71 - nothing happened yet, I guess the workflow has to be in the primary branch ?

@Rajpratik71
Copy link
Contributor

yes @ptrthomas, it should be in the primary branch.

Earlier, I raised the PR to "develop" as per policy.

@Rajpratik71
Copy link
Contributor

Now, you can cherry-pick the commit from "develop" to "master"

or Directly merge this PR #2155

@ptrthomas
Copy link
Member

@Rajpratik71 thanks a lot, I'll merge and clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants