Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI listen example fails to work after graal refactoring #2211

Closed
ptrthomas opened this issue Dec 7, 2022 · 9 comments
Closed

CLI listen example fails to work after graal refactoring #2211

ptrthomas opened this issue Dec 7, 2022 · 9 comments
Assignees
Milestone

Comments

@ptrthomas
Copy link
Member

this example: https://github.com/karatelabs/karate/blob/f18042b08a685d010bf3c01d8b881472ee7949de/karate-core/src/test/java/com/intuit/karate/core/fork-listener.feature

does not work anymore:

* def proc = karate.fork({ args: ['ping', 'google.com'], listener: listener })
js failed:
>>>>
01: karate.fork({ args: ['ping', 'google.com'], listener: listener })
<<<<
org.graalvm.polyglot.PolyglotException: class com.intuit.karate.graal.JsValue$SharableMembersAndInstantiable cannot be cast to class org.graalvm.polyglot.Value (com.intuit.karate.graal.JsValue$SharableMembersAndInstantiable and org.graalvm.polyglot.Value are in unnamed module of loader 'app')
- com.intuit.karate.core.ScenarioEngine.fork(ScenarioEngine.java:833)
- com.intuit.karate.core.ScenarioBridge.fork(ScenarioBridge.java:461)
- <js>.:program(Unnamed:1)
@ptrthomas
Copy link
Member Author

@bytebae - good news, I realized that this was a simple fix. it would be great if you build from source and validate that you don't get the JS multi-threaded error any more, you can find a developer guide here: https://github.com/karatelabs/karate/wiki/Developer-Guide

@bytebae
Copy link

bytebae commented Dec 16, 2022

Seems to work!

@ptrthomas
Copy link
Member Author

@bytebae okay, I'll post here when we release an RC version for either 1.4 or 1.3 - it may take a couple weeks

@bytebae
Copy link

bytebae commented Jan 4, 2023

Hello and Season's Greetings!

Wanted to thank you for providing the fix so quickly! Tests have been stable so far. Could you please share when a release with this fix is scheduled?

@ptrthomas
Copy link
Member Author

@bytebae thanks for your patience, to be honest I have to investigate this issue: https://stackoverflow.com/q/75008620/143475 and #2224 - and then make a release. so I estimate a couple more weeks

@bytebae
Copy link

bytebae commented Jan 5, 2023

OK. Thank you!

@ptrthomas
Copy link
Member Author

@bytebae 1.4.0.RC3 has been released, please try it and let us know

@bytebae
Copy link

bytebae commented Jan 10, 2023

Thank you very much! Seems to work so far. Will let you know if I come across any issues.

@ptrthomas
Copy link
Member Author

1.4.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants