improve exception details when karate.call fails in js script

[shrik18]

today when karate.call is made using js function it throws generic exception with no details

       * def fun =
          """
		function() {
		  		  try {
		    			  karate.call('classpath:com/intuit/karate/test/js-test-abstract.feature')
		  			   }catch (e){
		    				return(e);
		  			  }
		}
	"""
    * def e = fun()
    * print 'exception>>>',e

[print] exception>>> com.intuit.karate.KarateException: http call failed after 4519 milliseconds for url: https://localhost:8080/abcd/xyz/3.1
classpath:com/intuit/karate/test/js-test-abstract.feature:15

The actual exception is suppressed

19:33:57.062 [main] ERROR com.intuit.karate - javax.net.ssl.SSLException: Unsupported or unrecognized SSL message, http call failed after 425 milliseconds for url: https://localhost:8080/abcd/xyz/3.1

It will help adding these details to serve odd cases like https://stackoverflow.com/questions/55095314/

[ptrthomas]

this is low priority for us, anyone is welcome to contribute a PR

[shrik18]

I did some homework and seems this is the class tha would need change:

karate/karate-core/src/main/java/com/intuit/karate/core/Result.java

Lines 139 to 150 in 4257ec4

	public static Result failed(long nanos, Throwable error, Step step, StepRuntime.MethodMatch matchingMethod) {
	String message = error.getMessage();
	if (message == null) {
	message = error + ""; // make sure we show something meaningful
	}
	error = new KarateException(message + "\n" + step.getDebugInfo());
	StackTraceElement[] newTrace = new StackTraceElement[]{
	new StackTraceElement("<feature>", ": " + step.getPrefix() + " " + step.getText() + " ", step.getDebugInfo(), step.getLine())
	};
	error.setStackTrace(newTrace);
	return new Result(FAILED, nanos, error, false, matchingMethod);
	}

Change>>

    String message = error.getMessage();
    String errCause = error.getCause().getMessage();
    if (message == null) {
            message = error + ""; // make sure we show something meaningful
        }
    error = new KarateException(message + "\n" + step.getDebugInfo() + "\n" + errCause);

Output >>>>
19:31:17.003 [main] INFO com.intuit.karate - [print] exception>>> com.intuit.karate.KarateException: http call failed after 4610 milliseconds for url: https://localhost:8080/sapi/hws/3.1
classpath:com/intuit/karate/test/js-test-abstract.feature:15
java.lang.RuntimeException: org.apache.http.conn.HttpHostConnectException: Connect to localhost:8080 [localhost/127.0.0.1,

[ptrthomas]

@shrik18 that code has evolved over 6 years to keep the logs free of noise. I think getCause() can return null in some cases. anyway, a PR and thorough testing (and observation) is required.

[shrik18]

@ptrthomas agreed due diligence is required and indeed getCause() possibly can return null.
I have another solution where I can make this change.

karate/karate-core/src/main/java/com/intuit/karate/core/ScenarioEngine.java

Lines 594 to 612 in 4257ec4

	try {
	response = requestBuilder.client.invoke(httpRequest);
	} catch (Exception e) {
	long endTime = System.currentTimeMillis();
	long responseTime = endTime - startTime;
	String message = "http call failed after " + responseTime + " milliseconds for url: " + httpRequest.getUrl();
	logger.error(e.getMessage() + ", " + message);
	if (logger.isTraceEnabled()) {
	String stacktrace = StringUtils.throwableToString(e);
	if (stacktrace != null) {
	logger.trace(stacktrace);
	}
	}
	if (perfEventName != null) {
	PerfEvent pe = new PerfEvent(startTime, endTime, perfEventName, 0);
	capturePerfEvent(pe); // failure flag and message should be set by logLastPerfEvent()
	}
	throw new KarateException(message, e);
	}

Line 611 : this is where actual exception is added to cause. I can ammend this to
throw new KarateException(message +"\n" + e.getMessage(), e)

This way we are pretty much sure only http failures exceptions are added to message, and no risk of null pointer

Its up to you to choose the solution and I will raise a PR.

[ptrthomas]

@shrik18 yes that sounds good

[ptrthomas]

1.4.0 released