Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework logging mechanism (if possible) to not hard-depend on logback #408

Closed
ptrthomas opened this issue Jun 4, 2018 · 3 comments
Closed

rework logging mechanism (if possible) to not hard-depend on logback #408

ptrthomas opened this issue Jun 4, 2018 · 3 comments
Assignees
@ptrthomas
Labels
enhancement fixed
Milestone
v0.8.0

Comments

@ptrthomas
Copy link
Member

not sure if possible but couple of problems in the wild, one is this: #390 (very rare) and here is another: #268 (somewhat common where folks mix into existing code-bases)

and recently someone reported that it was not possible to mix karate into an existing project using log4j without switching everything to logback - which I find hard to believe and am still investigating - but this overall issue is certainly worth solving cleanly.

main challenge is retaining the existing capability of ReporterLogAppender - while providing an abstraction. should be doable with some interface magic etc. anyway karate follows the "pass the whole damn context around" philosophy, lol
@ptrthomas ptrthomas added this to the v0.8.0 milestone Jun 4, 2018
@ptrthomas ptrthomas self-assigned this Jun 4, 2018
ptrthomas added a commit that referenced this issue Jun 12, 2018
@ptrthomas
removed hard-dependency on logback in core #408
1e64b81 
those watching this repo please do help by testing
junit, parallel / json and javafx textarea seem to be working fine
in terms of http logs and output of print statements being captured
this should make it easier for teams to integrate karate into existing legacy java maven modules
@ptrthomas ptrthomas mentioned this issue Jun 13, 2018
Closed
@suhail-sullad
Copy link

Initial tests show new logger implementation is working. The mentioned issue is fixed.

@ptrthomas
Copy link
Member Author

@suhail-sullad great ! thanks for the confirmation

@ptrthomas
Copy link
Member Author

released 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrthomas ptrthomas

Labels
enhancement fixed
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@ptrthomas @suhail-sullad