Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about how to run a single scenario #1243

Merged
merged 1 commit into from Aug 3, 2020

Conversation

MahatmaFatalError
Copy link
Contributor

Description

Adds details to the README on how to run a single scenario via CLI and its limitations.

@ptrthomas
Copy link
Member

ptrthomas commented Aug 3, 2020

commenting here for the benefit of those interested in ACTUALLY fixing this:

as far as I know, both the JUnit4 and JUnit5 runners should behave the same way, look for this line:

feature.setCallLine(resource.getLine());

would be good if someone can debug the code and figure out what's going on

https://github.com/intuit/karate/blob/master/karate-junit5/src/main/java/com/intuit/karate/junit5/Karate.java

@ptrthomas ptrthomas merged commit be20da8 into karatelabs:develop Aug 3, 2020
@ptrthomas
Copy link
Member

added to project board: https://github.com/intuit/karate/projects/3#card-42997366

@ptrthomas
Copy link
Member

assigned to @Nishant-sehgal #1286 (comment)

@Nishant-sehgal
Copy link
Contributor

Nishant-sehgal commented Oct 19, 2020

@ptrthomas mvn test "-Dkarate.options=PathToFeatureFiles/order.feature:12" -Dtest=DemoTestParallel this is currently supported in Junit4 we need to check how we can support it in Junit 5.. this is the ask here correct?

@ptrthomas
Copy link
Member

@Nishant-sehgal yes, thanks !

@Nishant-sehgal
Copy link
Contributor

Nishant-sehgal commented Oct 19, 2020

@ptrthomas I see it is working as expected.Can you help me what is the issue here.
I ran the command mvn test "-Dkarate.options=--tags ~@ignore classpath:foo/foo-test.feature:8" -Dtest=FooRunner
Here is the output.
Screenshot 2020-10-19 at 9 00 26 PM

Pom file:
Screenshot 2020-10-19 at 9 03 42 PM

@ptrthomas
Copy link
Member

@Nishant-sehgal hmm, sorry about that. if @MahatmaFatalError does not respond within a few days - we can assume this is a non-issue

@ptrthomas
Copy link
Member

@Nishant-sehgal and you can make the PR to revert the documentation change. hope that helps !

@Nishant-sehgal
Copy link
Contributor

Thanks.Let’s wait for few days.

@ptrthomas
Copy link
Member

@Nishant-sehgal you can go ahead with a PR and revert the changes that @MahatmaFatalError made, thanks - new PR referencing this one should be good

@Nishant-sehgal
Copy link
Contributor

Yes will be raising a PR for this shortly.

@Nishant-sehgal
Copy link
Contributor

@ptrthomas Have raised the PR of removing limitation for Junit 5 for single scenario.
#1344

@ptrthomas ptrthomas removed this from the 1.0.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants