Issue-464: proper handling of abort and slight improved KarateJunitFormatter #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, I just realized it was raised against master instead of develop, closing it (will open a new one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @ptrthomas (#464), this PR is to
let karate.abort() also mark the remaining steps in that scenario as SKIPPED (same as the steps after failed step of a scenario)
slightly improve KarateJunitFormatter (invoke
updateElementinendOfScenarioLifeCycle)make sure the above changes still won't impact KarateJunitAndJsonReporter; it will report aborted scenario as passed (as it is doing in 0.8.0), please see newly added test case (FeatureResultTest.java)
make sure KarateHtmlReporter can identify skipped steps (after abort() or failure) of a scenario are marked properly
Relevant Issues : Issues with skipped tests in summary and html report #464
Relevant PRs : (optional)
Type of change :