Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-479-1: UI enhancements to handle runAll / runUpto using JavaFX Service/Task #481

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

vmchukky
Copy link
Contributor

@vmchukky vmchukky commented Aug 2, 2018

Description

Patch to fix the pending item from #425 (comment)

Currently the threading model needs work, the status of step execution reflects only at the end of ALL steps. needs to be fixed

We were invoking runAll() / runUpto() in the Java FX Application thread, which was causing varPanel / logPanel updates to be taken up only after all steps are executed. Introduced RunService to offload these (runAll/runUpto) and free Java FX Application thread.

Also added a unit test case (not sure of what happens when running tests on a headless / no-display system). It ran fine in my local setup, will wait for the test results and then may be remove the newly added test.

@vmchukky
Copy link
Contributor Author

vmchukky commented Aug 2, 2018

As expected, am seeing
Running com.intuit.karate.ui.ThreadTest
Exception in thread "Thread-1" java.lang.UnsupportedOperationException: Unable to open DISPLAY

Let me disable the newly added unit test (ThreadTest.java)

@ptrthomas ptrthomas merged commit b93d58a into karatelabs:develop Aug 2, 2018
@ptrthomas
Copy link
Member

this is really great work, thanks ! I'll rename the test to be a little more convenient to run in the IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants