Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data races, bump helm-client/helm #5

Merged
merged 1 commit into from Feb 1, 2022
Merged

Fix data races, bump helm-client/helm #5

merged 1 commit into from Feb 1, 2022

Conversation

Hamcha
Copy link
Collaborator

@Hamcha Hamcha commented Feb 1, 2022

  • Removes all detected data races (via go run -race)
    • Logs don't write over each other anymore
    • No "concurrent map write" crashes hopefully
    • Only one mutex!
  • Bump github.com/mittwald/go-helm-client to v0.8.4 and helm.sh/helm/v3 to v3.7.2, to remove an inner data race

The Helm version bump means generated files will have slight different format (spacing mostly).

Signed-off-by: Alessandro Gatti <alessandro.gatti@mikamai.com>
@Hamcha Hamcha self-assigned this Feb 1, 2022
Copy link
Collaborator

@MatteoJoliveau MatteoJoliveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants