Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded Private Key #111

Closed
sihoang opened this issue Dec 14, 2020 · 3 comments
Closed

Hardcoded Private Key #111

sihoang opened this issue Dec 14, 2020 · 3 comments

Comments

@sihoang
Copy link

sihoang commented Dec 14, 2020

I was wondering why the private key is hardcoded in the main config
https://github.com/kardiachain/go-kardia/blob/master/cmd/cfg/kai_config.yaml#L19

 P2P:
    PrivateKey: 8843ebcb1021b00ae9a644db6617f9c6d870e5fd53624cefe374c1d2d710fd06
    ListenAddress: tcp://0.0.0.0:3000
    MaxPeers: 25
@lewtran
Copy link
Collaborator

lewtran commented Dec 23, 2020

It's a private key that map with the address in genesis file for local development. We will update the proper config.
Thank you for your contribution

@lewtran lewtran mentioned this issue Dec 26, 2020
Merged
lewtran added a commit that referenced this issue Dec 26, 2020
@lewtran
Merge pull request #118 from kardiachain/update/remove_hardcoded_pk
c791915 
Remove hardcoded pk in test configs #111
@lewtran
Copy link
Collaborator

lewtran commented Dec 26, 2020

@sihoang please check the PR and close this issue

@lewtran
Copy link
Collaborator

lewtran commented Dec 29, 2020

Closed due to no response

@lewtran lewtran closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sihoang @lewtran