Update txs synchronization and tx pool #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhkv
approved these changes
Jul 30, 2020
| sender, err := types.Sender(tx) | ||
| // TODO: @lew | ||
| // Double check to ensure the signer | ||
| sender, err := types.Sender(types.HomesteadSigner{}, tx) |
There was a problem hiding this comment.
why HomesteadSigner? If it's that old, we should just use our own Signer
| } | ||
| n := rand.Intn(len(pending)) + 1 | ||
| for _, s := range pending { | ||
| if n--; n == 0 { |
There was a problem hiding this comment.
shoud it just be "if n-- ==0" ?
|
|
||
| // If we're reorging an old state, reinject all dropped transactions | ||
| // var reinject types.Transactions | ||
|
|
There was a problem hiding this comment.
should add comment why you comment this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maybe resolve #15
First it will mark the txs pool and pop txs if they're oversize the pool
https://github.com/kardiachain/go-kardiamain/blob/update/tx_pool/kai/service/peer.go#L321
The txs will sync in a channel and disconnect from p2p if there is no more pending txs
https://github.com/kardiachain/go-kardiamain/blob/update/tx_pool/kai/service/protocol_manager.go#L87
It's also break the txs to chunks and send async them over the network #13
https://github.com/kardiachain/go-kardiamain/blob/update/tx_pool/kai/service/peer.go#L401