New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service(darwin): fix status regression #273

Merged

kardianos merged 1 commit into kardianos:master from saracen:fix-darwin-status

Jun 10, 2021

Contributor

saracen commented Jun 1, 2021

In https://github.com/kardianos/service/pull/196/files#diff-5f554888209e6e12e2ac42ca24862cf09e282924e4c31b7e15c67320ac300d7eR190

"failed with stderr" was replaced with "failed with StandardError". However, the message received is still failed with stderr: https://github.com/kardianos/service/blob/master/service_unix.go#L104

On macOS, this means the status command fails when uninstalled, installed or stopped. The only valid state is when the service is actively running.


          service(darwin): fix status regression

682e80c

coveralls commented Jun 1, 2021

Coverage remained the same at 12.799% when pulling 682e80c on saracen:fix-darwin-status into ef35c56 on kardianos:master.

kardianos merged commit 82b10ec into kardianos:master

djdv mentioned this pull request

Fix: macos status #287

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment