Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication Status incorrectly set for Completed series with non-integer issue numbers. #3085

Open
bioman1000 opened this issue Jul 28, 2024 · 2 comments
Labels
discussion In active discussion

Comments

@bioman1000
Copy link

What happened?

Completed comic series containing non-integer (0/0.5/etc) issue numbers shows up as "Ended" rather than "Completed": I own all 145 issues of Invincible including the "0" Issue for a total of 145 issues (which is the Issue Count in my ComicInfo.xml taken from ComicVine), but Kavita seems to set the "owned issue count" as the max issue. number rather than that actual issue number.
image

What did you expect?

Series should count non-integer issue numbers to set Publication Status.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.2 - Stable

What operating system is Kavita being hosted from?

Docker (LSIO Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome, Safari

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

Safari

Relevant log output

No response

Additional Notes

No response

@bioman1000 bioman1000 added the needs-triage Needs to be triaged by a developer and assigned a release label Jul 28, 2024
@bioman1000
Copy link
Author

bioman1000 commented Jul 28, 2024

image Can confirm that it looks to default to the max issue number (or at least the last one published) if you look at this series that has a 200 issue.

@majora2007
Copy link
Member

The problem here is that issue 0 is an issue and according to the spec, count is the number of issues, not the highest issue number.

https://anansi-project.github.io/docs/comicinfo/documentation#count

@majora2007 majora2007 added discussion In active discussion and removed needs-triage Needs to be triaged by a developer and assigned a release labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion In active discussion
Projects
Development

No branches or pull requests

2 participants