Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LDkit Context to Options #79

Closed
karelklima opened this issue Dec 17, 2023 · 1 comment · Fixed by #86
Closed

Refactor LDkit Context to Options #79

karelklima opened this issue Dec 17, 2023 · 1 comment · Fixed by #86
Assignees
@karelklima
Labels
question Further information is requested
Milestone
2.0

Comments

@karelklima
Copy link
Owner

TODO:

  • Rename: Context -> Options
  • Rename: setDefaultContext -> setGlobalOptions
  • Remove dependency on Comunica
  • Add engine option, instead of having Engine separate
  • When options are passed to Lens, the resulting options should be a combination of global options and local options.
@karelklima
Copy link
Owner Author

Cons: both Comunica and RDFJS types use Context name for this.

@karelklima karelklima added the question Further information is requested label Dec 17, 2023
@karelklima karelklima added this to the 2.0 milestone Dec 17, 2023
@karelklima karelklima self-assigned this Jan 3, 2024
@karelklima karelklima mentioned this issue Jan 3, 2024
Merged
karelklima added a commit that referenced this issue Jan 3, 2024
@karelklima
Refactored LDkit Context to Options (#86)
c77d220 
Resolves #79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karelklima karelklima

Labels
question Further information is requested
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Refactored LDkit Context to Options karelklima/ldkit
1 participant
@karelklima