Skip to content

Commit

Permalink
build-sys: use $LIBS rather than LDFLAGS
Browse files Browse the repository at this point in the history
Fixes: #1349
Signed-off-by: Karel Zak <kzak@redhat.com>
  • Loading branch information
karelzak committed Jun 18, 2021
1 parent 5a82610 commit 75cba8d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 22 deletions.
8 changes: 4 additions & 4 deletions configure.ac
Expand Up @@ -845,7 +845,7 @@ char *c = crypt("abc","pw");
have_libcrypt=no
have_crypt=yes
],[
UL_SET_FLAGS([], [], [-lcrypt])
UL_SET_LIBS([-lcrypt])
AC_LINK_IFELSE([AC_LANG_PROGRAM([[
#ifdef HAVE_CRYPT_H
#include <crypt.h>
Expand All @@ -861,7 +861,7 @@ char *c = crypt("abc","pw");
],[
AC_MSG_WARN([crypt() is not available])
])
UL_RESTORE_FLAGS
UL_RESTORE_LIBS
])
AM_CONDITIONAL([HAVE_LIBCRYPT], [test "x$have_libcrypt" = xyes])

Expand All @@ -883,10 +883,10 @@ AS_IF([test "x$with_selinux" = xno], [
UL_PKG_STATIC([SELINUX_LIBS_STATIC], [libselinux])
AM_CONDITIONAL([HAVE_SELINUX], [true])
UL_SET_FLAGS([], [], [$SELINUX_LIBS])
UL_SET_LIBS([$SELINUX_LIBS])
# This function is missing in old libselinux 1.xx versions
AC_CHECK_FUNCS([security_get_initial_context])
UL_RESTORE_FLAGS
UL_RESTORE_LIBS
])
])
AC_SUBST([SELINUX_LIBS])
Expand Down
29 changes: 11 additions & 18 deletions m4/ul.m4
Expand Up @@ -67,28 +67,21 @@ AC_DEFUN([UL_SET_ARCH], [
])


dnl UL_SET_FLAGS(CFLAGS, CPPFLAGS, LDFLAGS)
dnl
dnl Sets new global CFLAGS, CPPFLAGS and LDFLAG, the original
dnl setting could be restored by UL_RESTORE_FLAGS()
dnl
AC_DEFUN([UL_SET_FLAGS], [
old_CFLAGS="$CFLAGS"
old_CPPFLAGS="$CPPFLAGS"
old_LDFLAGS="$LDFLAGS"
CFLAGS="$CFLAGS $1"
CPPFLAGS="$CPPFLAGS $2"
LDFLAGS="$LDFLAGS $3"
dnl UL_SET_LIBS(LIBS)
dnl
dnl Sets new global LIBS, the original setting could be restored by UL_RESTORE_LIBS()
dnl
AC_DEFUN([UL_SET_LIBS], [
old_LIBS="$LIBS"
LIBS="$LIBS $1"
])

dnl UL_RESTORE_FLAGS()
dnl UL_RESTORE_LIBS()
dnl
dnl Restores CFLAGS, CPPFLAGS and LDFLAG previously saved by UL_SET_FLAGS()
dnl Restores LIBS previously saved by UL_SET_LIBS()
dnl
AC_DEFUN([UL_RESTORE_FLAGS], [
CFLAGS="$old_CFLAGS"
CPPFLAGS="$old_CPPFLAGS"
LDFLAGS="$old_LDFLAGS"
AC_DEFUN([UL_RESTORE_LIBS], [
LIBS="$old_LIBS"
])


Expand Down

0 comments on commit 75cba8d

Please sign in to comment.