Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure.ac #1349

Closed
wants to merge 1 commit into from
Closed

Update configure.ac #1349

wants to merge 1 commit into from

Conversation

Hello71
Copy link
Contributor

@Hello71 Hello71 commented Jun 16, 2021

  1. the test incorrectly used AC_COMPILE_IFELSE instead of AC_LINK_IFELSE, defeating the purpose of checking -lcrypt.
  2. the test did not properly restore LIBS, causing later checks to all fail if libcrypt wasn't found.
  3. HAVE_LIBCRYPT only controls whether to use -lcrypt, it is not needed or used in any source files.

1. the test incorrectly used AC_COMPILE_IFELSE instead of AC_LINK_IFELSE, defeating the purpose of checking -lcrypt.
2. the test did not properly restore LIBS, causing later checks to all fail if libcrypt wasn't found.
3. HAVE_LIBCRYPT only controls whether to use -lcrypt, it is not needed or used in any source files.
@karelzak
Copy link
Collaborator

Merged with small changes. Thanks!

@karelzak karelzak closed this Jun 17, 2021
@Hello71
Copy link
Contributor Author

Hello71 commented Jun 17, 2021

oops, i actually wrote a better commit message but github squashed it at some point. oh well

@Hello71
Copy link
Contributor Author

Hello71 commented Jun 18, 2021

your change is not compatible with --as-needed (standard on almost all distros now) or static linking. libraries need to be in LIBS, not LDFLAGS. the similar check for security_get_initial_context will also never succeed on modern distros. fedora example: https://kojipkgs.fedoraproject.org//packages/util-linux/2.37/2.fc35/data/logs/x86_64/build.log "checking for security_get_initial_context... no". yet https://kojipkgs.fedoraproject.org//packages/util-linux/2.37/2.fc35/data/logs/x86_64/root.log says "DEBUG util.py:446: libselinux x86_64 3.2-2.fc35 build 83 k" which does have security_get_initial_context: https://github.com/SELinuxProject/selinux/blob/libselinux-3.2/libselinux/src/get_initial_context.c

karelzak added a commit that referenced this pull request Jun 18, 2021
Fixes: #1349
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak
Copy link
Collaborator

karelzak commented Jun 18, 2021

Oh, that's a stupid thing. It's really useless with --as-needed. Fixed.

Thanks!

@asavah
Copy link

asavah commented Jun 18, 2021

@karelzak commit 75cba8d breaks crypt() detection.

ncurses and other libs detection seems to work fine

EDIT: scratch that, I haven't had my git tree fully updated, 75cba8d actually fixes the issue introduced by an earlier commit.
Sorry for the noise,

karelzak added a commit that referenced this pull request Jul 20, 2021
Fixes: #1349
Signed-off-by: Karel Zak <kzak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants