Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsmartcols ASCII art problem #137

Closed
martinpitt opened this issue Jan 6, 2015 · 2 comments
Closed

libsmartcols ASCII art problem #137

martinpitt opened this issue Jan 6, 2015 · 2 comments

Comments

@martinpitt
Copy link

Forwarding from https://launchpad.net/bugs/1406133:

The libsmartcols component used by findmnt to draw the filesystem tree is smart enough to wrap lines in case the output doesn’t fit into the screen. However, it fails to draw the lines correctly in this case. Attached patch fixes the problem. Someone more knowledgeable in libsmartcols internals might want to change the buffer size from an arbitrary 1024 to something taken from actual data, the best way to do that eludes me.

Sample of incorrect output:

├─/boot /dev/sda1 ext3 rw,relatime,data=ordered
├─/usr /dev/mapper/vgshadow-ubuntu_usr
                                                ext4 rw,noatime,data=ordered
├─/var /dev/mapper/vgshadow-ubuntu_var
                                                ext4 rw,noatime,data=ordered
├─/home /dev/mapper/vgshadow-home
                                                ext4 rw,noatime,data=ordered
└─/srv /dev/mapper/vgshadow-srv
                                                reiserfs rw,noatime,notail

Patch adds missing vertical lines at any level necessary.

The patch is here: https://launchpadlibrarian.net/193614209/libsmartcols-art-fix.diff

@martinpitt
Copy link
Author

The bug report/patch is by Roman Odaisky (https://launchpad.net/~rdaysky), but he did not provide an email address.

@karelzak
Copy link
Collaborator

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants