Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Swift Package Manifest for Swift 4.2 / 5.0 #6

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Updates to Swift Package Manifest for Swift 4.2 / 5.0 #6

merged 3 commits into from
Mar 30, 2019

Conversation

Kaiede
Copy link
Contributor

@Kaiede Kaiede commented Mar 29, 2019

Starting with Swift 4.2, the old v3 manifest starts throwing warnings that it is deprecated. Now with Swift 5 out the door, the old v3 manifest no longer builds at all.

This PR does two things:

  1. Adds a Package@swift-4.swift manifest using the v4 manifest. This silences the warning and makes it possible to build for Swift 5, while not losing the ability to build for Swift 3. At least until a code change breaks it.
  2. Updates the CI configuration to build/test a bunch of Swift compiler versions. On Linux: Swift 3.1.1, Swift 4.1.3, Swift 4.2.3, Swift 5.0. On Mac: Xcode 9.4 and 10.

This is required for supporting Swift 5 going forward and to silence a warning in Swift 4.2. Should not regress Swift 3.1.1 support.
@kareman kareman merged commit 19e3ee1 into kareman:master Mar 30, 2019
@kareman
Copy link
Owner

kareman commented Mar 30, 2019

Excellent stuff, I had forgotten you could have several Package.swift files. Thank you, I will release these changes in a new version.

@kareman
Copy link
Owner

kareman commented Mar 30, 2019

@Kaiede But do you think a lot of people are still using Swift 3? This project is currently using 2 deprecated methods, which give warnings when running xcodebuild from the command line (but strangely not when running from Xcode). Fixing these warnings means dropping support for Swift 3.

@Kaiede
Copy link
Contributor Author

Kaiede commented Mar 30, 2019

I’m mostly leaving it in because I haven’t fully deprecated Swift 3 in my project yet.

4.1.3 was only recently “fixed” for Rapsberry Pi and other 32-bit ARM devices a couple months ago.

I’m in the middle of doing the work to move off Swift 3, and onto 4.1.3 (32-bit) and 5.0 (64-bit).

Once that’s done, I can certainly do the deprecation for Swift 3 on Moderator as well.

@kareman
Copy link
Owner

kareman commented Mar 30, 2019

No problem, I’ll leave it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants