-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI test for generating migrations #31
Conversation
def test_migrations_directory_does_not_exist(self, timestamp): | ||
timestamp.return_value = '20160423231932' | ||
filename = '{}_a_new_migration.py'.format(timestamp()) | ||
expected_path = '/tmp/dbmigrator-tests/m/{}'.format(filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly better to use the standard library's tempfile
for windows compatibility? But then again, I see you ref /tmp
in many places. So maybe something to address when and if the need arises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course, I got used to just using /tmp
. Fixed.
I'm not sure how to fix the travis failure 馃槕 |
@pumazi If this looks ok, since it's only one commit, could you use the merge button that squashes the commit? 馃槃