Fix python3 schema diff to output as str #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running migrations in python3, the schema diff is displayed: ``` Running migration 20170810093842 create_a_table b"--- \n+++ \n@@ -38,20 +38,31 @@\n $$;\n \n \n ALTER FUNCTION public.karen_trigger() OWNER TO travis;\n \n SET default_tablespace = '';\n \n SET default_with_oids = false;\n \n --\n+-- Name: a_table; Type: TABLE; Schema: public; Owner: travis; Tablespace: \n+--\n+\n+CREATE TABLE a_table (\n+ name text\n+);\n+\n+\n+ALTER TABLE a_table OWNER TO travis;\n+\n+--\n -- Name: schema_migrations; Type: TABLE; Schema: public; Owner: travis; Tablespace: \n --\n \n CREATE TABLE schema_migrations (\n version text NOT NULL,\n applied timestamp with time zone DEFAULT now()\n );\n \n \n ALTER TABLE schema_migrations OWNER TO travis;\n" ``` `str` and `byte` are mixed together causing the output to be hard to read. Change schema diff to display as `str`.
|
Python 2 tests are failing because testing.py uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running migrations in python3, the schema diff is displayed:
strandbyteare mixed together causing the output to be hard to read.Change schema diff to display as
str.