Add quiet switch. Convert most output to logging #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedstrm
force-pushed
the
quiet-and-log
branch
from
0ab4065
to
2876a81
Compare
|
Hmm, I broke all the tests. Code works, though :/ |
reedstrm
added a commit
to openstax/cnx-db
that referenced
this pull request
Oct 23, 2017
|
😆 No problems. I'll fix them later. It's something I thought about doing. |
|
I was going to recommend to Sisi that she be sure to run script/ci_test_migrations.sh, but then I realized it's massively unreadable output - great for CI, bad for human. |
|
BTW, here's the commit I use this in: openstax/cnx-db@38d06ac |
reedstrm
force-pushed
the
quiet-and-log
branch
from
2876a81
to
b628aac
Compare
karenc
force-pushed
the
quiet-and-log
branch
2 times, most recently
from
c18fef5
to
d204d04
Compare
Instead of using print to output debug or warning messages, use the dbmigrator logger instead. That way, it is possible to customize the output by using `setLevel` etc.
There were no tests covering cases for when migrations are not found or if there are no migrations to rollback.
As is, dbmigrator is a bit chatty. I will take advantage of this in cnx-db/script/ci_test_migrations.sh to make non-CI invocation almost completely silent, so migration failures stand out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, dbmigrator is a bit chatty. Move most output to logger.info, and add a quiet switch. I will take advantage of this in cnx-db/script/ci_test_migrations.sh to make non-CI invocation almost completely silent, so migration failures stand out.