Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tie::StdHash from prereqs #3

Closed
wants to merge 1 commit into from

Conversation

miyagawa
Copy link

Tie::StdHash doesn't exist as a require-able module, hence no Module::Metadata inspection either.

The problem only happens when you don't have a working C compiler, since the dep seems to become a hard requirement when there's no CC.

Entering B-Hooks-EndOfScope-0.14
Checking configure dependencies from META.json
Checking if you have ExtUtils::MakeMaker 6.58 ... Yes (6.66)
Checking if you have ExtUtils::CBuilder 0.26 ... Yes (0.280210)
Configuring B-Hooks-EndOfScope-0.14
Running Makefile.PL
Warning: prerequisite Tie::StdHash 0 not found.
Checking if your kit is complete...
Looks good
Writing Makefile for B::Hooks::EndOfScope
Writing MYMETA.yml and MYMETA.json
-> OK
Checking dependencies from MYMETA.json ...
Checking if you have Module::Runtime 0.014 ... Yes (0.014)
Checking if you have Hash::Util::FieldHash 0 ... Yes (1.10)
Checking if you have Tie::Hash 0 ... Yes (1.04)
Checking if you have Module::Implementation 0.06 ... Yes (0.09)
Checking if you have Scalar::Util 1.10 ... Yes (1.27)
Checking if you have base 0 ... Yes (2.18)
Checking if you have Tie::StdHash 0 ... No
Checking if you have strict 0 ... Yes (1.07)
Checking if you have constant 0 ... Yes (1.27)
Checking if you have warnings 0 ... Yes (1.18)
Checking if you have Sub::Exporter::Progressive 0.001011 ... Yes (0.001011)
==> Found dependencies: Tie::StdHash
Searching Tie::StdHash (0) on cpanmetadb ...
skipping S/SH/SHAY/perl-5.20.2.tar.gz
-> FAIL Installing the dependencies failed: Module 'Tie::StdHash' is not installed
-> FAIL Bailing out the installation for B-Hooks-EndOfScope-0.14.

@shadowcat-mst
Copy link

And since Tie::StdHash is 'inside' Tie::Hash the Tie::Hash dep is sufficient.

@miyagawa
Copy link
Author

correct. Also, I found that the Makefile.PL is really custom, so I needed to update that file as well. Pushed another fix that does that.

@miyagawa
Copy link
Author

Ugh, it looks like I was working on a branch off of slightly outdated master. Updated and rebased!

OK - looks like when I run dzil build it will still add "Tie::StdHash" as a hard requirement. Is it prereq scanner doing this? It must be stopped.

➜  B-Hooks-EndOfScope git:(no-tie-stdhash) ag StdHash B-Hooks-EndOfScope-0.15 
B-Hooks-EndOfScope-0.15/lib/B/Hooks/EndOfScope/PP/FieldHash.pm
28:  use base 'Tie::StdHash';

B-Hooks-EndOfScope-0.15/Makefile.PL
25:    "Tie::StdHash" => 0,
53:  "Tie::StdHash" => 0,

B-Hooks-EndOfScope-0.15/META.json
143:            "Tie::StdHash" : "0",

B-Hooks-EndOfScope-0.15/t/00-report-prereqs.dd
114:                                      'Tie::StdHash' => '0',

The package exists on 02package, but this module cannot be required since Tie/StdHash.pm
does not exist by itself.
@karenetheridge
Copy link
Owner

OK - looks like when I run dzil build it will still add "Tie::StdHash" as a hard requirement. Is it prereq scanner doing this? It must be stopped.

It's in runtime-recommends at the moment (in master's HEAD).

@miyagawa
Copy link
Author

It's in runtime-recommends at the moment (in master's HEAD).

Right, because it's in the "Soften" bundle right? If I delete Tie::StdHash from the soften list like this pull request, it will be added as a hard dep now.

@karenetheridge
Copy link
Owner

it's cool, I'll make it work! :)

karenetheridge added a commit that referenced this pull request May 13, 2015
karenetheridge added a commit that referenced this pull request May 14, 2015
karenetheridge added a commit that referenced this pull request May 14, 2015
  - updated the tooling for generating Makefile.PL
  - removed Tie::StdHash from prereqs, which is not require()able as a module
    on its own (despite being indexed) (miyagawa, GH #3)
  - fixed the addition in release 0.14 of Hash::Util::FieldHash as a
    prerequisite (which is not available prior to perl 5.010) for pure-perl
    installations (RT#104435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants