Straighten up how exceptions are detected in the 'wanted' callback #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The detection of the directories that must be skipped when collecting perl files was pretty lax. In particular, it abused regexps of the form
m![^\\/]?inc!
, probably with the goal of allowing both"inc"
and"/inc"
. Unfortunately,m![^\\/]?inc!
can match a lot of other things, such as"vincent"
, which happens to appear in myTEMP
environment variable, and which ultimately made the test suite fail.I've rewritten this whole section to use
File::Spec->splitdir
to split the directory name in chunks, and then decide on whether the directory should be skipped depending on their value. The result should be more deterministic.The
m!Build$!
regexp that appears next line should probably be anchored as well, but I'll leave that to your appreciation.I'd advise you to roll an alpha release out first before making it official, since this change touches a core path of the module.
Vincent