fix(--require): Resolve project local modules in npx context #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing a local TypeScript module and using `--require=ts-node/register` option, node was trying to resolve it inside the temporary npx folder. This behaviour doesn't currently make sense, now modules required via this option are always resolved relative from the current working directory of the script. This currently prevents requiring a module that only exists in the npx context, but that could be added back easily if needed. https://nodejs.org/docs/latest-v10.x/api/all.html#modules_require_resolve_request_options
|
@saurabh2590 this solves the problem we had recently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing a local TypeScript module and using
--require=ts-node/registeroption,node was trying to resolve it inside the temporary npx folder.
This behaviour doesn't currently make sense, now modules required via this option
are always resolved relative from the current working directory of the script.
This currently prevents requiring a module that only exists in the npx context, but that could be added back easily if needed.
https://nodejs.org/docs/latest-v10.x/api/all.html#modules_require_resolve_request_options