src/types.rs: fix complete_challenge() for non-standalone mode#29
Merged
1c3t3a merged 1 commit intokariustobias:mainfrom May 6, 2024
trofi:fix-non-standalone
Merged
src/types.rs: fix complete_challenge() for non-standalone mode#291c3t3a merged 1 commit intokariustobias:mainfrom trofi:fix-non-standalone
1c3t3a merged 1 commit intokariustobias:mainfrom
trofi:fix-non-standalone
Conversation
`Path::join` throws away prefix if apppended path is an absolute path:
$ evcxr
>> std::path::Path::new("/a").join("/b")
"/b"
As a result non-standalone mode failed to create absolute
`/.well-known/acme-challenge` path and failed.
The change creates it within `WEB_ROOT` prefix.
Collaborator
|
Better late than never! This LGTM :) Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path::jointhrows away prefix if apppended path is an absolute path:As a result non-standalone mode failed to create absolute
/.well-known/acme-challengepath and failed.The change creates it within
WEB_ROOTprefix.