Thumbnail generation and test fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a split on . for the full path of the input file is not going to work out well if one of the parent directories of the input file has a dot in it. So let's say if we have an input file with the following path: /foo.bar/shiny_image.png The basename of the resulting thumbnail would be: foo.thumbnail_XXXxYYY.png So instead of using the full path of the input file for determining the first path of the new thumbnail file name we now solely use its basename. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 3, 2016
Packaging itself is pretty much straightforward, the tests however revealed a few issues, which I have fixed with a small patch that has been upstreamed at karlch/vimiv#32. The other sed-based patches in postPatch are mostly NixOS-specific. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Using ls and tr means that we have two external commands just to iterate through the $PATH environment variable. This not only is kinda pointless to do (we *can* do this in Python without forking off) but is also error-prone because it relies not only on ls/tr being there but also on their outputs being correct. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
If you run nosetests with arguments, the argument parser of vimiv picks it up and execution may fail depending on which arguments are passed. We now explicitly pass sys.argv to the main() function via vimiv/vimiv.py and via main_test.py, so that if we call the main() function via code we *never* provide arguments implicitly. This also makes the arguments kvarg of parse_args() mandatory, because there is no other code in the codebase that doesn't explicitly pass arguments. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
|
The changes look good to me and all make sense, thanks a lot for your contribution! EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled over a few issues while packaging vimiv for NixOS:
$PATHrelies on external tools.main_testpicks upnosetestsarguments.This branch should fix these issues.